mimic: osd/PeeringState: do not complain about past_intervals constrained by oldest epoch #30222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neha-ojha
reviewed
Sep 6, 2019
smithfarm
force-pushed
the
wip-41502-mimic
branch
from
b934dcc
to
40bea70
Compare
|
@neha-ojha Thanks - I somehow neglected to add that comment even though I knew it was needed. Also there was a make check failure first time around, but I didn't get a chance to look at it - let's see if it happens a second time. |
tchaikov
reviewed
Sep 7, 2019
… oldest epoch The start of the required interval has a floor set by the oldest osdmap epoch we have. That can lead to an invalid/empty required interval (because the start is >= the end), but the PG may still have past intervals. That can be cause by a slow PG deletion. No need to complain about this harmless condition. Fixes: https://tracker.ceph.com/issues/39546 Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit b139677) Conflicts: src/osd/PeeringState.cc - file does not exist in mimic; made the changes manually in src/osd/PG.cc - mimic has a different way of getting the oldest osdmap
smithfarm
force-pushed
the
wip-41502-mimic
branch
from
40bea70
to
6129289
Compare
tchaikov
approved these changes
Sep 7, 2019
neha-ojha
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/41502
backport of #29747
parent tracker: https://tracker.ceph.com/issues/39546
this backport was staged using https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh